Fix a few TLS compliance issues#10594
Open
kareem-wolfssl wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens TLS compliance-related behavior in the core handshake and exporter paths, primarily by enforcing correct timing/validity constraints for keying material export and session ticket usage.
Changes:
- Refuse
wolfSSL_export_keying_material()calls until the handshake has fully completed (per RFC 8446 / RFC 5705 intent). - Suppress use of expired stored session tickets (fall back to full handshake instead of attempting resumption).
- Map
BUFFER_Etodecode_errorinTranslateErrorToAlert().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/ssl.c |
Adds a “handshake complete” gate before exporting keying material. |
src/internal.c |
Adds client-side session ticket expiry suppression and extends alert translation for buffer errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
kareem-wolfssl
force-pushed
the
zd21873
branch
2 times, most recently
from
June 10, 2026 19:04
133b754 to
9528e7c
Compare
dgarske
reviewed
Jun 11, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
Skoll Code Review
Scan type: reviewOverall recommendation: COMMENT
Findings: 4 total — 3 posted, 1 skipped
2 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Medium] Expired-ticket branch drops SessionTicket extension entirely; client may no longer obtain a fresh ticket —
src/internal.c:31665-31687 - [Medium] No tests added for the three new compliance behaviors —
tests/api.c - [Low] Redundant dual condition in keying-material handshake-complete gate —
src/ssl.c:4076-4080
Skipped findings
- [Low]
Preprocessor directives indented to code column instead of repo convention
Review generated by Skoll
dgarske
requested changes
Jun 11, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
See skoll review #10594 (review)
…hout tls.c/tls13.c. Thanks to Ben Smyth for the report.
Thanks to Ben Smyth for the report.
Thanks to Ben Smyth for the report.
…set. This should fix hostap EAP-FAST failures.
…NULL_CIPHER_IN_DEFAULT is defined. Thanks to Ben Smyth for the report.
Contributor
Author
|
Retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially fixes zd#21873
Testing
Built in tests
Checklist